Insure landing page

Community feedback

• 

  

  Emmilie Estabillo•5,600

  @emestabillo

  Posted over 4 years ago

  Hi Marta, great job! Site seems responsive. The roles are not necessary in this case because they are redundant. You already used the proper html tags to define landmarks in your document. Check out this [article] (https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Navigation_Role) which clearly explains the purpose of the roles.

  A few more thoughts:

  • On larger screens, the entire .wrapper is left-aligned

  • The social media icons in the footer could use a tags. Hover states are also missing there and in the mobile nav.

  • Minor changes in font styling should get the page closer to the design

  Hope this helps :-)

  22
• 

  

  ApplePieGiraffe•30,525

  @ApplePieGiraffe

  Posted over 4 years ago

  Hello, Marta! 👋

  Always nice to see you complete another challenge! 😀 Well done on this one! Everything looks pretty good and responds well! 👍

  Two minor things I suggest are,

  • Adding a hover state to the social media icons near the bottom of the page.
  • Perhaps adding a max-width to the bottom-most button in the mobile navigation so that it isn't too wide when the layout first changes from desktop to tablet.

  Keep coding (and happy coding, too)! 😁

  10