Insure Landing Page - SCSS, Grid, Flexbox, JS

Community feedback

• 

  

  Matt Studdert•13,611

  @mattstuddert

  Posted over 4 years ago

  It's awesome to see you post another solution, Anna. Welcome back! 👋

  Your code looks great, scales up/down nicely, and it's awesome to see you using min-width media queries! The only suggestions I could find were in your HTML:

  • You've duplicated the navigation code when you don't need to. Instead of duplicating the HTML, you could style the nav differently for mobile or desktop layout inside a media query.
  • It's great to see you using a button element to trigger the mobile menu. If you want to take it up a notch and make it more accessible, I'd recommend checking out this Inclusive components article on menus & menu buttons. Add aria-* attributes will really enhance the accessibility of the navigation.
  • You've got 3x img elements with alt text of "illustration". These add no context to the content, so I'd recommend leaving the alt attributes blank, making screen readers skip them. As it is, screen readers would read out the word "illustration" before each of those 3 blocks, which doesn't add anything and actually makes the experience worse.

  I hope that helps. Let me know if you have any questions! 👍

  12
• 

  

  ApplePieGiraffe•30,525

  @ApplePieGiraffe

  Posted over 4 years ago

  Hello, Anna! 👋

  I'm so happy to see you submit another solution! 😆 (I was wondering when you'd come back!) 😉

  Excellent job, as always, of course. Everything looks good and responds nicely! I like the fade in/out transition you added to the mobile navigation. 🤩

  Your code looks clean and organized, too. 👍

  Well, keep coding (and happy coding), as always! 😁

  12