Interactive Rating Component using HTML, CSS and JS

Community feedback

• 

  David•7,960

  @DavidMorgade

  Posted almost 3 years ago

  Hello Wesley, congrats on finishing the challenge! your app works perfectly and has the proper checks for the submit button

  Don't feel overwhelm in your first JS project, the important thinks when learning a new technology or programming language is to get it to work, doesn't matter if it's spaguetti code or not, is your first project and it works so the job is done!

  Your JS looks pretty good structured and you are using loops and if checks impresive for a first Javascript project IMO. You could have use a forEach loop to make it a bit more clear instead of a for of loop, wich actually is faster but less readable, for example something like:

  form.addEventListener('submit', function (event) {
      event.preventDefault();
      radioButtons.forEach((button, index) => {
             if(!button.checked) return;
              rating.append(button.value);
              mainContainer.classList.add('fade-in');
              innerContainer.classList.add('hide');
              innerContainer2.classList.remove('hide');
       })
  })
  

  Instead of checking it is checked, you can check if its not checked and instantly return, at the end is the same thing, also removed the console.log

  You can see that the differences are minimal, consider that I did write this code just here in this comment and didn't check the functionality!

  Hope my feedback helps you, keep going with those JS challenges!

  11

  Marked as helpful
• 

  Enmanuel Otero Montano•2,155

  @Enmanuel-Otero-Montano

  Posted almost 3 years ago

  Hello Wesley!

  Congratulations

  Your solution for this challenge is correct, there are other ways to do it, but yours is also valid. Now you can look at other solutions to this challenge from other colleagues and you can compare and learn. Keep practicing with JavaScript and it will get easier and easier

  For the depressing and difficult don't worry, that will also help you deal with the frustration, very present in programming.

  Note: I have been up to 25 days to achieve a solution.😂😂😂

  11

  Marked as helpful