Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

Intro section using HTML5 & Flexbox

Nour Al-Osman•60
@nalosman
A solution to the Huddle landing page with a single introductory section challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I'm a little rusty, it's been a while, and I'm trying to get back to it. I put the code through the w3 html and css validator, so on that front it should be ok. When I pressed 'tab' it went through the register button and the social media icons.

One question I had is if using <a> vs <button> is better in this example.

If there's any general feedback after looking at the site and/or the code, especially with layout and spacing, I would appreciate it.

Thank you and Cheers✌️✌️

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • imad•3,330
    @imadvv
    Posted almost 3 years ago

    Greetings Nour Al-Osman!! Congratulations on completing Your 3rd challenge!, 👏👏👏. well done.

    I take a look at your code and have some general suggestion for you, Hope you found it useful.

    I don't know if you know this but when You're using flex you have access to the gap Property, which let you add spacing between rows or columns very easy, so can add a spacing to social media icons just like so .social-icons { gap : 1rem;}, and also for the button or actually on general when You have a :hover style on interactive element also include :focus to it, that for the keyboard users when they are navigate with the tap and focusing over that element the styles that apply on hover will apply on focus too, something like this .reg-btn:hover , .reg-btn:focus {...},

    and for your question this is document form a11y-101 has an excellent explanation to this question , but the simple rule is to use <a> for Links and navigation between Pages/Views, and <button type=""> for actions that have a function to handle it.

    this page for example the social-media should be a <a> tag because they are link to a social media pages and <button> for reg-btn because normally they are a function that will run when user click to register.

    " I try my best on this, please correct me if am wrong, I'm on the learning process "

    but over all, Happy Codding Rusty Man, Have a Good Day/Night

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub