Skip to content
Submitted almost 4 years ago

IP-Address-Tracker

Jean•335
@JeanMieses
A solution to the IP Address Tracker challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

This is my second time doing this project. I was not happy with the first one. I had a lot of layouts issues, so I decided to improve it and re-submit it. I feel I could improve upon it and I am fine with the current result.

Pls, I will appreciate any feedback. How does the code look? Can you read it without problems? What about the layouts? What would you recommend me to change or do?

Code

Please log in to post a comment

Log in

Community feedback

  • Amon•2,560
    @A-amon

    Hello! Great work~ It's responsive too.

    I have a few suggestions:

    1. Seems like you were trying to align the input element using margin-top. Remove it and set align-items:center in the form.

    2. Add a border:none to the submit button to remove the default border.

    3. Put .data in a same div either with .search-bar or #map. Then, adjust the positioning accordingly.

    4. If you want to leave the label element empty, you can opt to use aria-label attribute on the input element instead. This way, you can remove the unused label element.

    5. Put the main content into main tag.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord