Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Your session has expired please log in again.
Your session has expired please log in again.
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

"Kinda" Responsive GitHub-user-search-app using HTML, CSS, JS, &React

@LonelyBuddy

Desktop design screenshot for the GitHub user search app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


First time using React, could I have some feedback on CSS and file structure. I know it's a mess... Thank you so much. :)

Community feedback

@xolott

Posted

Hi @LonelyBuddy

Awesome solution! I have some comments:

  • To improve the accessibility of your solution add the attribute aria-hidden="true" to decorative images like the user's profile picture and the svg icons
  • Try to use Semantic HTML. Your code should include at least a main element

After you make those changes don't forget to push your changes to GitHub and generate the accessibility report one more time.

I really like how it looks! Pixel-perfect solution!

Edit:

Just one more note:

  • Practice the separation of concerns on your code. The presentation layer (the react components) should don't know about the business logic (how you fetch the API). You can try something like Callbacks hooks in react (to begin with something) or Redux (recommended approach)

Marked as helpful

1

@LonelyBuddy

Posted

@xolott Thank you so much for the feedback! I'll take a look at those notes online.😃

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord