Jose Truyol• 50
@xolott
Posted
Hi @LonelyBuddy
Awesome solution! I have some comments:
- To improve the accessibility of your solution add the attribute
aria-hidden="true"
to decorative images like the user's profile picture and thesvg
icons - Try to use Semantic HTML. Your code should include at least a
main
element
After you make those changes don't forget to push your changes to GitHub and generate the accessibility report one more time.
I really like how it looks! Pixel-perfect solution!
Edit:
Just one more note:
- Practice the separation of concerns on your code. The presentation layer (the react components) should don't know about the business logic (how you fetch the API). You can try something like Callbacks hooks in react (to begin with something) or Redux (recommended approach)
Marked as helpful
1
Henry Zheng• 420
@LonelyBuddy
Posted
@xolott Thank you so much for the feedback! I'll take a look at those notes online.😃
0