Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

landing page responsive using flex

@AlexSiqueiraLopes


Design comparison


SolutionDesign

Solution retrospective


Any feedback is welcome.

Community feedback

P
Ken 4,915

@kens-visuals

Posted

Hey @AlexSiqueiraLopes 👋🏻

I've got some quick tips to help you fix the accessibility issue and some other things.

  • In your markup, <div class="container">...</div> should be <main class="container">...</main>. This will fix the accessibility issue. Just, don't forget to generate a new repot once you fix it.
  • Also, I suggest implementing :hover state on the button and on the icons, which you can find in design folder active-state image, after you implement it you can also add transition: all 0.2s; to the button and the links, this will make :hover smoother.
  • In general, avoid using word like logo, illustration, because they become redundant for the people who use screen reader. So in this case, it should be like this: <img src="images/logo.svg" alt="Huddle">.
  • For the browser image, add aria-hidden="true”, because it's for decoration. You can read more about aria-hidden here. To illustrate:
<img class="tm" src="images/illustration-mockups.svg" alt="" aria-hidden="true”>

I hope this was helpful 👨🏻‍💻 other than that, nicely done, keep it up. Cheers 👾

Marked as helpful

0

@AlexSiqueiraLopes

Posted

@kens-visuals thank you!!! Great tips on the accessibility issue, thanks for the feedback. I've already added it to the code.

0
P
Ken 4,915

@kens-visuals

Posted

@AlexSiqueiraLopes no problem 😇

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord