Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Landing page using flexbox and grid

-_RIkka 140

@devsimocastles


Design comparison


SolutionDesign

Solution retrospective


I did this inside a header tag, is that a bad practice?

Community feedback

ROCKY BARUA 1,090

@Drougnov

Posted

Hello @RikkaaDev, great design. As you asked, yes, it is actually a bad practice. We should only put the logo and nav (if needed) inside the header. The actual content should be wrapped around the main tag. If you want to explore more here is a blog about when to use header

The design looks great but the image looks a little bit small on mobile devices. Use width:100% with media queries to give it full width.

Again, great job. Have a good day my friend :)

Marked as helpful

0
Old 6,240

@Old1337

Posted

Hello there! 👋

Congratulations on finishing your challenge! 🎉

I have some feedback on this solution:

  • Always wrap all of the elments inside <main> except header.

**if my solution has helped you do not forget to mark this as helpful!

Marked as helpful

0
Naveen Gumaste 10,480

@NaveenGumaste

Posted

Hay ! RIkka Good Job on challenge

These below mentioned tricks will help you remove any Accessibility Issues

-> Add Main tag after body <main class="container"></main>

-> Learn more on accessibility issues

If this comment helps you then pls mark it as helpful!

Have a good day and keep coding 👍!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord