Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Landing Page with Single service section- CSS Flexbox

pvcodes 55

@pvcodes2020


Design comparison


SolutionDesign

Solution retrospective


Please help me get better with my Coding skills with your valuable feedback!!

Community feedback

P
ApplePieGiraffe 30,565

@ApplePieGiraffe

Posted

Hi there, pvcodes! 👋

Nice to see you complete another challenge! 😀 Good effort on this one! 👍

A few things I suggest are,

  • Adding min-height: 100vh to the body to make sure it always at least as high as the viewport.
  • Switching to a mobile-friendly layout a little sooner to prevent the content of the page from becoming too squished right before the layout changes.
  • Adding cursor: pointer to the submit button and social media links at the bottom of the page.

Keep coding (and happy coding, too)! 😁

1

pvcodes 55

@pvcodes2020

Posted

@ApplePieGiraffe Oh yes!! I will keep them in mind and will update them ASAP in my next commit. Thanks for your prompt feedback. I sincerely appreciate it.

Thanks again, PV Codes

1
P
ApplePieGiraffe 30,565

@ApplePieGiraffe

Posted

@pvcodes2020

NP! 👍

0
P

@MarkoNikolajevic

Posted

Hi pvcodes!

As @ApplePieGiraffe said you did a good job on it.

I've noticed a few things

  • on mobile view the div with class="social-icons" overlaps the paragraph text because you used position: absolute setting right and bottom. I suggest you to remove this styles and add to center elements
display: flex;
justify-content: center;

Keep on coding :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord