@pikapikamart
Posted
Hey, really nice work on this one. The desktop state looks great, site is responsive and the mobile state looks great as well.
Others already gave their feedback on this one which is really nice to see giving feedbacks for other members:>. For some other suggestions, here are some:
- For this one, a preferred markup would be like this:
<header />
<main />
<footer />
The header
contains the website-logo, main
for main-content and footer
for the social-medias. If you use a landmark, like a header
inside the main
, it will just be treated as a normal tag so always have its own row beside the main
if needed.
- Lose the word logo in the website
img
alt
attribute. When usingimg
tag, you don't need to add words that relates to "graphic" such as "logo" and others, sinceimg
is already an image so no need to describe it as one. - Don't use
width: 100vw
since this will only add a horizontal scrollbar at the bottom, since this value does not account the vertical scrollbar's width. - The hero-section image is just a decorative since there are no other info about the illustration. Decorative images should be hidden for screen-reader at all times by using
alt=""
andaria-hidden="true"
to theimg
tag or onlyaria-hidden="true"
if you are usingsvg
instead ofimg
tag. - Only use descriptive
alt
on images that are meaningful and adds content to the site otherwise hide the image for screen-reader users. - Lastly, since those social media are supposed list of "links", use
a
tag for each icon. Eacha
tag that wraps the social-media icon should have eitheraria-label
attribute orsr-only
text inside it, defining where the link would take them. For example, you should usefacebook
as the value if the link would take the user to facebook.
Aside from those, great job again on this one.
Marked as helpful
@BenjaDotMin
Posted
@pikapikamart Hey! Thanks so much for the detailed feedback. I definitely have a weakness with SEO and accessible html, so this is great advice for me.
I am going to find this so useful, thanks again.