Made with css grid (and added a small animation for the first time!)

Community feedback

• 

  solvman•1,650

  @solvman

  Posted over 1 year ago

  Hi @JanAbe 👋

  Very well done! 👍 Congratulations! 🎉

  I have a few minor suggestions that might help you to improve your project:

  • ⭐️ Consider swapping background color with text/button color. The background color should be lighter than the text/button color.
  • ⭐️ There is a minor clipping issue when the width is 670px to 600px. That is caused by the fact that there is no space left to shrink the width anymore due to the fixed button size and padding/margin around it. There are a couple of ways you can address it. One way is to add min-width (it will add an annoying scroll bar at the bottom). Or you could make your whole layout jump to mobile at 670px vs 600px.
  • ⭐️ There is a button shifting issue on the widths of 702px-713px, 818px-794px, and 990px-950px. That is caused by the hard-set margin-top on your button element. Perpahs, consider making each card a flex/grid container and adding align-self: flex-end to the button class to make buttons "stick" to the bottom of the container.

  Otherwise, great job! 🎊 I hope you find my comments useful 🫶

  12

  Marked as helpful