@lucasdaher
Latest comments
- @JanAbe
Nice work, it looks sick!
One point of feedback though is that you use pixels to set the font-size.
This is considered a bad practice because when a user increases his font-size in the browser, the text doesn't get larger 'cause it isn't responsive.
Here is a blog post about it: https://fedmentor.dev/posts/font-size-px/
Hope this helps
Marked as helpful - @belkysupreme22@JanAbe
Nice work!
Feedback:
It's a good idea to use landmarks in your html.
You could for example use a
<main>landmark to put in all your main content.https://developer.mozilla.org/en-US/blog/aria-accessibility-html-landmark-roles/#the_main_landmark
It is also a good idea to use the
<form>tag for forms instead of a div.Hope this helps
- @itzvikashgupta@JanAbe
Looks sick and nice usage of landmarks in your html! The only thing is that the background-image doesn't take up all space on my screen. You can fix this using
background-size: cover. - @Paula-Tony@JanAbe
Nice solution but maybe you could add landmarks to your HTML.
A header to contain the logo, a main to contain the content of the page, and a footer to contain the social links!
Marked as helpful - @JanAbe@JanAbe
Fixed the problem by changing
height: 100svhtomin-height:100svh. Thank you @AlexKMarshall over on discord for helping me !
