Meet landing page, mobile first, SASS and BEM notation

Community feedback

• 

  P

  David Lemvigh•200

  @dlemvigh

  Posted 5 months ago

  The visual

  • There is a scrollbar near the faces
  • The purple buttons are a bit brighter in color that design

  Generally really good solution, nice and responsive on all screen sizes.

  The code

  • Nice semantic html
  • Well organized css classes
  • An elegant solution to the desktop faces. The design shows the faces closer to the edges. But with your solution that could easily be changed by adding justify-content: space-between to the .banner__container. (I also like your design better than the figma design on that front)
  • I think the cause of the scrollbar is the overflow-x: hidden, which I don't understand the reason for. Removing it removes the scrollbar. (It is not the first time I've see overflow-x/overflow-y having unexpected interactions, but I don't know/remember why)

  Note: I tested in Chrome on Windows 11, if that helps with debugging the scrollbar.

  00