@emestabillo
Posted
Hi Vivien, great job! I agree that the star background is an awesome solution! Here are some thoughts:
-
I noticed you used a lot of
id
s for this project. I suggest sticking toclass
es if you're not using the div for JS or scrolling link.Id
s have a high specificity and therefore much harder to override should you need to in the future. -
You can simplify your html by doing away with some of the containers.
page-container
,content-wrap
, andflex-container
can probably be condensed into one. -
The
div
s can also be exchanged for more semantic HTML. -
The background patterns are missing on medium widths.
Hope this helps! :-)
@vivienbalint
Posted
Thank you! :)