P
Matt Studdert• 13,611
@mattstuddert
Posted
Amazing work on this challenge, John! It looks really nice and scales down perfectly to mobile 👍
I've got a couple of small pointers after taking a look at your code, which hopefully you'll find helpful:
- You don't actually need the extra
li
in the navigation to create dot and the line. Instead, you could style a::before
pseudo-element to add that extra detail. This would save you the extra list item in your HTML. - You're using a
div
on the.menu-btn
class at the moment. This means that anyone not able to use a trackpad/mouse to navigate the site won't be able to access the mobile menu. Instead, I'd use an interactive element like abutton
, so that it gains focus if someone is tabbing through your content.
I hope that helps, let me know if you have any questions! 👍
0