David Payne• 1,205
@dpayne713
Posted
Hi Rafet,
Nice Job! looks nice and works well!
-
It appears the background image for 'light' mode is a broken link. I've also had that issue when using GitHub pages - I'm pretty sure that is one of the main reasons that this site recommends using Vercel.
-
I kinda wish that instead of an alert for the clear completed it popped up a hidden
divor something instead. -
another super minor note - when you choose 'completed' the completed checkbox is not selected on those elements making it ever so slightly confusing as to if the item is completed or not.
Hope this helps,
David
2
rafet• 925
@rafetbasturk
Posted
@dpayne713
Hi David!
First of all thanks for your feedback. About your recommendations;
- In the screenshot light mode's image seems normal. As you said it may be github originated.
- Pop-up is a good idea. I should have thought of it.
- Since it is already "completed" tab, I thought there is no need to check and line-through items anymore. Anyway I changed the code as you suggested and uploaded it.
Happy coding,
Rafet
0
