Looking to hire developers?
Finally, completed this challenge where I implemented mobile-first workflow for first time plus implemented as successful JS for the first time as well.
My only question is how can I make the SVG color change like white as it is black naturally, plus is there any way to make my share-icon animation any smoother at the end during second click.
THANKS in advance for your valuable feedback's.
@A-amon
Posted
Hello, great work! I think it would be better if you use the button tag for the share button because well, it's a button. To change the svg's color, I can only think of using the svg code itself then use the fill CSS property to change its color. The share arrow seems to be a little cropped on the left.
Marked as helpful
@Skyz03
Posted
@A-amon Thanks will check it out and implement it
@ConradMcGrifter
Posted
I would change your img to have a width:100% instead of max-width:100% since it doesnt fill the box initially while shrinking down to mobile size. also add a height of 100% to the img, as well as object-fit:cover;
Marked as helpful
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
