Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

My first QR code challenge using HTML and CSS

Cathiscoding•20
@cathleys
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I'm done with the challenge so far and I don't know how to display the favicon. I got lots of difficulties on GitHub lol because this is my first time using it.

If there are things you see that need tweaking, please let me know.

If the codes are understandable and clean? is the media query rule I used correct?

please give me your reviews on my code if you have time.

Thank you to all!!

Have a great day!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Andreas Remdt•950
    @andreasremdt
    Posted almost 3 years ago

    Hey, congrats on solving the challenge :)

    I checked your favicon, it's is used and displayed correctly, so no worries there.

    In my opinion, your code is clean and understandable. One suggestion I have is to use the main element for the container instead of a div. This gives you accessibility benefits because every page is supposed to have one main landmark, here it's the card itself.

    The media query is technically correct, but I don't think that you need one here. Instead, what you can do is setting max-width: 100% on the image itself, which will make it responsive. You can even remove the width: 290px. This way, the image grows and shrinks with the browser without the need to write any media queries. This is also a great way of making videos and other media responsive in CSS. Hope it helps :)

    Marked as helpful
  • Chamu•13,860
    @ChamuMutezva
    Posted almost 3 years ago

    Greetings Cathleys,

    Indeed , well done on your first challenge. Some of my points have been raised already but here is what i think:

    • the image is not responsive in a way, @andreasremdt has addressed it above, it is a good idea to reset images to max-width: 100% - that will make sure that the image can fit fully without overlapping when the container is smaller or the fixed width that had been applied with css. You have currently set the width to 290px, check the site using dev tools or on a mobile that has a screen size of less than 375px , you will notice that the image is overlapping the container. But with a max-width of 100%, the image will be contained in it's container.
    • for font sizes , i would suggest to use rems instead of px , you can read more on this px vs rem

    Happy coding

    Marked as helpful
  • Madiha Khan•420
    @madkn1311
    Posted almost 3 years ago

    Hello Cathleys,

    Good job on your first challenge..!!

    What I noticed in the CSS for the container is that you have used both width and max-width. Since max-width overrides width so its better to use just max-width.

    All the best for the next challenge. :)

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub