Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT preview card component

#accessibility#bem#fetch#jquery#itcss

@ayushbhargava22

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@adityas24

Posted

Hey Ayush good job.

I saw that you are using margins to give spaces around the elements inside the card. For example in <div class="nft-img"></div> and <div class="owner"></div>.

Do not use margins for this purpose. Use padding instead. Margins are used when we want to give space between two adjacent elements. But to give space around the element always use padding.

All the best 🙂👍

Marked as helpful

1

@ayushbhargava22

Posted

@adityas24 Thank you will keep this in mind

0
Rio Cantre 9,710

@RioCantre

Posted

Hello there! Good job in this project. You did well in implementing the design and I would like to suggest the following for you...

  • Add the hover state for the fonts, for example...
.nft-name:hover {
  color: hsl(178, 100%, 50%);
  cursor: pointer;
}

.name:hover {
  color: hsl(178, 100%, 50%);
  cursor: pointer;
}
  • Adjust the top position of the container into 50% and add a padding of padding: 0.5rem;
  • Adjust the size in the .nft-name into 22px and add a padding of padding: 0.5rem 0;
  • Change the color value in the .nft-sub-info into color: hsl(215, 51%, 70%); and add font-size: 15px; and padding: 1rem 0;
  • Change the color value of nft-price into color: hsl(178, 100%, 50%);
  • Inside the .owner p change the color with color: hsl(215, 51%, 70%);
  • Wrap the content container with main tag and attribution with footer tag for readability

Hope this helps and Keep going!

Marked as helpful

0

@ayushbhargava22

Posted

@RioCantre Thank you will change and update these

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord