Skip to content
OverviewSolutions
2
Comments
27

Aditya Singh

@adityas24India460 points

SDE-1 | Full Stack MERN Developer

Latest solutions

Latest comments

  • Aditya Singh•460
    @adityas24

    Hi Fiqih

    I couldn't get what exactly is your problem? Can you tell in detail?

  • Aditya Singh•460
    @adityas24

    Hi Sanjog, i loved your site, great job!

    For creating those lines, you can simply give border-bottom to the first and the second boxes you have created. That is the best way to do it i think.

    If you still want to follow any other path, you can use div tag and give it width, height and background color. But why to create tags unnecessarily if you can do it just by adding border-bottom. This would be a bad practice.

    Do mark it as helpful if it helped you. Happy coding!

  • Aditya Singh•460
    @adityas24

    Hi Saswat, great effort by you!

    I saw that for displaying the person's image, you are using background image. But the image tag is the most appropriate way to display image here. For more information read this stackoverflow answer on background image vs img tag

    Hope it was helpful, Happy coding!

    Marked as helpful
  • Aditya Singh•460
    @adityas24

    Hi Dhanya, Great work by you. I found following irregularities in your HTML

    1. Instead of writing this <div class="header"> Improve your front-end skills by building projects </div> You could have written

         <h2> Improve your front-end skills by building projects </h2>

    It is semantically better code. And not necessary to use h2 tag. You can use any heading tag according to requirement

    2. And you should have used paragraph tag here

         <div class="text-copy">
          Scan the QR code to visit Frontend Mentor and take your coding skills to 
           the next level
      </div

    Instead of above code, you should write <p> Scan the QR code to visit Frontend Mentor and take your coding skills to the next level </p>

    Here right tag to be used is paragraph tag.

    Thanks, Happy coding.

    Marked as helpful
  • Aditya Singh•460
    @adityas24

    Hey Szymon, great job , a very well semantic html written by you. I think writing good semantic HTML is harder to master than CSS.

    And I would like to suggest you that avoid applying any styles on the body element. Make habit of not doing it from the very beginning. All the best!

    Marked as helpful
  • Aditya Singh•460
    @adityas24

    Hey Teo! you did very well in your first challenge. I would like to suggest you the following....

    You could have avoided the div you used to wrap the h1 and p. As you have not used any style on div. Then you can simply avoid using it. It will not affect the semantics and will also decrease the length of the code.

    So you could simply write

    <div class="container">
      <img src="images\image-qr-code.png" alt="QR code">
      <h1>Improve your front-end skills by building projects</h1>
      <p class="text">Scan the QR code to visit Frontend Mentor and take your coding skills to the 
         next level</p>
</div>

    All the best 🙂👍

    Marked as helpful
View more comments