Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT preview card component

@hejkeikei

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback will be appreciated:)

Community feedback

Ahmed Bayoumi 6,800

@Bayoumi-dev

Posted

Hey Ting-Huei Chen, It looks good!...

My suggestions:

  • All page content should be contained by landmarks, Contain the attribution with <footer>.
<footer>
   <div class="attribution">
      //...
   </div>
</footer>
  • Center the component on the page with Flexbox, by giving the parent element <main> the following properties:
main {
   display: flex;
   justify-content: center;
   align-items: center;
   min-height: 100vh;

   /* padding: .8rem;    <--- Remove */
   /* margin-top: 4rem;     <--- Remove */
 }  

Some Resources

Hope this is helpful to you... Keep coding👍

0

@hejkeikei

Posted

Hi @Bayoumi-dev Thank you so much! that was informative:) Flexbox does make center component vertically easier.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord