Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

notification page using html, scss, flexbox and vanilla js

#sass/scss#bem
Jakub 110

@JKuba61

Desktop design screenshot for the Notifications page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Honestly it seemed pretty easy, however took me longer than I expected (could be because I'm rusty as I havent done any excersises in a long time plus my cat was destroying my flat and I couldnt focus :P )

Will gladly take feedback from you guys One minor issue was the font - i've looked up on the internet but i couldnt get the font imported into my project

Community feedback

@sumanth-chandana

Posted

Hi Jakub!, congrats🎉 on completing the challenge. Better take care about following points.

  • Always check Frontendmentor Report Generator issues after submitting the project for removing errors and warnings.
  • Use the alt (alternate text) attribute as mentioned in your Accessibility Report. alt attribute is used for Screen readers applications.
  • Why does alt attribute matter? Read here.
  • To avoid accessibility issues "All page content should be contained by landmarks" use code as :
 <body>
    <main>
        ---your code here----
    </main>
  <footer>
  </footer>
</body>

(why does <main> matter? Read here )

  • For proper centering the container(whole card) vertically and horizontally you can also use the following simple block of code use code:
body {
    min-height: 100vh;
    display: grid;
    place-content: center;
}
  • When we open the GitHub repository link, you will find an About Section on the right side. There, also include a live preview link of your project. It is better for someone to check your live project while interacting with code.

I hope you will find this Feedback Helpful.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord