@Miculino
Posted
Good job on completing your first challenge, Herson!
I know it can be really intimidating at first, but with each challenge you complete, you become more confident in your coding skills. So, well done on completing this Frontend Mentor challenge!
I had a look at your live solution and I also looked through your code and I have a few suggestions / observations I'd like to share with you.
In no particular order, here they are:
-
As @Drougnov pointed out, when you imported the font from Google Font, you only selected the 300 weight and that's why you can't use the bold weight in your design. Add the 600 or 700 weight to your import and it should work just fine after that.
-
A best practice for CSS is to reset the margin and padding of all elements using the * selector. You can also add the border-box property which will make sure that the padding and margin are added to the element's total width and height. You can see an example here: https://stackoverflow.com/questions/46923610/css-resetting-margin-and-padding/46923672
-
You might want to look into BEM methodology for a neat way to structure your HTML classes. If not, just try to keep in mind that your code should read like prose. Always use classes that can be understood by other developers, if they were to read through your code.
-
Instead of using absolute values like px, try to implement relative units like rem. I saw you've used vh on the body element, but there was no reason to set a 100vh height on the body in that case.
-
As @skyv26 pointed out, you don't have any media queries which means your project won't be responsive. You need media queries to make your project look good and structured no matter the device you use to see the website.
All in all, you've done a great job for your first project. I also suggest you have a look through https://www.frontendmentor.io/resources and use those resources to improve your skills as a developer.
Keep up the good work and looking forward to seeing more of your projects here on Frontend Mentor!
Marked as helpful
@Hersonmei
Posted
@Remus432
Thank you very much for the tips!
I've already used box-sizing: border-box in some tutorials, but I didn't really remember to put it in my code. Thanks for remembering, I'll try not to forget anymore!
That's right, after taking some classes on absolute and relative values, I'm going to start applying the next projects.
I added media queries to the project, I think I managed to implement it correctly. I applied for the 375px cell phone, but I was in doubt about how to apply it to the desktop (1440px) because my page was initially made based on the desktop.
Do I need to do both media queries (375px and 1440px)?
Thanks again for the tips, they were very useful and made me study some points so that the next projects come better.