Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Order Summary Component Solution using Css flexbox

@Jeth0214

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

P
Emmilie Estabilloā€¢ 5,540

@emestabillo

Posted

Hi @Jeth0214, great job looks really close to the design. A few things:

  • Remove all margin-top from main. Add min-height: 100vh instead to center the component on the screen

  • On mobile, the 'Change' link is touching the side of the enclosing div. If you reduce the padding around card__body, the issue would resolve itself.

  • The box-shadow looks a tad heavy

I think there was a lot of EXACT measuring involved since the screenshot looks pretty much flushed with the dimensions of the card in the design. While this practice is ok (within reason), I highly suggest focusing more on making your site fluid for different screen widths instead of how it would look against the screenshot. Imagine how frustrating it will be if you're given a multi-page project :-)

Hope this helps and thanks for tagging me on Slack!

Marked as helpful

1

@Jeth0214

Posted

@emestabillo ,Thanks for the feedback. I try your recommendation about the min-height. You are right, I will do the trick . Nice tips. I try to update it .

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord