Community Feedback

• 0

  Hey, good work on this one and for mithril? Hmm never heard about that before.

  There are couple of suggestions from me

  1. Excess usage of H1. In your markup, you used multiple h1 tags which is not recommended especially if it is a single page. Changing them to other tags will be great. Following best practices is really good.

  2. Button. Your learn more is supposed to be a link right and I think button element is not the right element to use in here, it is supposed to be a tag.

  Aside from those mentioned. Your work is good. It resizes well when going in mobile as well as the layout in the desktop^

  

  pikamart2,730Posted 1 week ago

  Reply

  • 0

    Hello, @pikamart! Thanks for taking a look.

    1. As far as I know, it's ok to each article have its own h1, as the specification says. Could you explain why it's not recommended?

    2. I don't think that the layout explicitly shows they're links, they could be buttons to open a modal, for example. But I see that they could be links as well.

    Thank you again and happy coding!

    

    felipeog660Posted 6 days ago

    Reply
  • 0

    @felipeog - Yes, they need to have each heading tags on its own, like h2 h3, but h1 is supposed to be used only one per page and is usually the top most header text of your webpage. You can use, but 1 h1 per page is considered the best practice.

    • I was also hesitant for that as well since yes, it could be a modal, but for common it will be a link

    Thank you as well ^

    

    pikamart2,730Posted 6 days ago

    Reply
  • 0

    Hey, @pikamart! Thanks for the follow up.

    The one h1 tag per page rule is valid for HTML versions prior to HTML5. The solution was made with HTML5.

    You're right about links being more common, I will change them soon. Thanks!

    Keep coding!

    

    felipeog660Posted 6 days ago

    Reply

  Add a comment
• 1

  Hello, Felipe Oliveira! 👋

  Nice to see you complete this challenge! 😀 It is a simple one, but you've done a good job on everything! 👍

  I had actually never heard of Mithril.js before, but I think it sounds interesting (haha, especially since it's named, well, "Mithril"). Probably something I should check out sometime! 😅

  Of course, keep coding (and happy coding, too)! 😁

  P

  ApplePieGiraffe19,700Posted 1 week ago

  Reply

  • 1

    Hey, @ApplePieGiraffe!

    Hahaha! Mithril is new to me as well.

    I wanted to try it out as its docs says it's smaller and performs better than other popular frontend frameworks. I just learned the very basics yet.

    It was fun, I recommend you to try it yourself.

    Happy coding!

    

    felipeog660Posted 6 days ago

    Reply

  Add a comment

Give some feedback to felipeog about their solution