Felipe Oliveira

@felipeog
Brazil
660Points

Frontend Developer @ Winnin Brasil

Latest Solutions

Latest Comments

  • Felipe Oliveira has commented on Marco's "3 Column Preview Card using Sass" solution

    1

    Hey, @devMarco02!

    Your solution looks perfect and it's responsive. The issues report is clean too, congrats! Nice use of CSS variables, good to see that it's documented with comments.

    My suggestions would be to take a look at one of the CSS methodologies, like BEM. The HTML could be more semantic too, using main, section and article tags.

    I noticed that there is a duplicate of <link rel="preconnect" href="https://fonts.gstatic.com" /> in the HTML file that could be removed.

    Happy coding!

  • Felipe Oliveira has commented on Natallia Harmon's "Card component" solution

    1

    Hello, @natalliasdh!

    The solution is almost pixel perfect and the report is clean, awesome!

    If you allow me to suggest, you could use semantic elements. I think the .container could be an article and the stats list could be an ul.

    Happy coding!

  • Felipe Oliveira has commented on aok's "Profile Card using HTML + CSS (Flex, BEM) questions about spacing + bg" solution

    3

    Hello, @kvcarido!

    I think you did a great job, the solution is really close to the design and the report is clean. Congrats!

    • There is horizontal scroll due to the way you did the background, using img tags. Using the background-image property would be a better approach. You can set multiple backgrounds, one for the top left, and one for the bottom right: https://www.w3schools.com/css/css3_backgrounds.asp
    • Instead of using position: relative, you could try using negative margin-top
    • You are breaking some BEM rules, instead of .card__stat .subtext, you could simply use .card__subtext, as BEM does not encourage block dependency

    Hope it helps!

  • Felipe Oliveira has commented on Botch's "Only HTML CSS Flexbox & JavaScript!" solution

    2

    Hello, @eZapataCode!

    I think you did a great job. The site is responsive and the accordions work. Good to see comments on the CSS.

    Some suggestions I have:

    • I believe that using the background pattern as .illustration-div's background-image would be a better approach
    • When an accordion is open, the arrow should be pointing up and the question should be bold
    • The FAQ title should be bold
    • There are some report issues, try to fix them
    • The code indentation is inconsistent, you could use a formatter plugin

    Hope it helps!