Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML5, CSS3 and BEM

Felipe OG 730

@felipeog


Design comparison


SolutionDesign

Solution retrospective


Any feedback is appreciated!

Community feedback

P
ApplePieGiraffe 30,545

@ApplePieGiraffe

Posted

Hello, once again, Felipe Oliveira! 👋

Nice to see another solution from you (and good job on it)! 👍 Overall, your site looks pretty great! 👏

Like fraserwat touched on, I think there's quite a bit of empty space to the sides of the design in the tablet/mobile layouts. It should be fine to allow the image (and the text) to be a little bigger so that the content of the page takes up more space and presence in the tablet layout (and simply allow them to further decrease in size when necessary).

Also, I think the design JPGs are simply guidelines for those specific screen dimensions but it's expected to adjust the layout and add intermediary layouts between desktop and mobile layouts when necessary. 🙂

Keep coding (and happy coding, too)! 😁

0

Felipe OG 730

@felipeog

Posted

Hello, @ApplePieGiraffe! Thanks for taking a look.

I will improve the layout soon, following the feedback from you and @fraserwat.

Happy coding!

0
Fraser Watt 1,790

@fraserwat

Posted

This looks great! The one thing I'd add is that you could probably afford to have the mobile version have a bit of a bigger max-width (especially as the other layout doesn't kick in until 1200px)

0

Felipe OG 730

@felipeog

Posted

Hello, @fraserwat! Thank you for taking a look.

I thought about it before submitting the solution, but as the mobile version expands horizontally, the illustration gets too big, drawing too much attention to it. I thought it didn't look very good.

Also, the style guide specifies 375px of width for the mobile version, so I ended up following it.

Thank you for the feedback and happy coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord