Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

Ping Coming Soon

Kate Dames•250
@funficient
A solution to the Ping single column coming soon page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Finally got the validation and display of the error message right, but still struggling to get the hover fill-color of the social icons white. How do I modify the svg fill color on hover?

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Tshepiso•110
    @Gandalf-hash
    Posted over 1 year ago

    Hello Kate, Ek hoop dit gaan goed and what a beatiful layout you have here. However when viewing the layout, I noticed that the input element seems to dominate the container, taking up around 80% of the width, leaving only 20% for the button. This may result in an imbalanced visual hierarchy. Additionally, on smaller devices, it seems that both the button and the input expand to the full width of the container, arranged in a column format.

    To improve this layout and enhance the visual appeal, I would recommend the following adjustments:

    Consider distributing the space more evenly between the input and the button. For example, you could allocate 70/30 of the width to each element respectively to achieve a more balanced appearance.

    Instead of fixed pixel values for the input and button, you might want to use relative units like percentages or viewport units.

    Lastly, Consider using CSS Grid or Flexbox layout for more fine-grained control over the positioning and sizing of your elements.

    I'll make you an example of how you might structure your CSS for equal distribution and responsiveness below:

    .container { display: flex; flex-wrap: wrap; }

    .input-container { flex: 1; max-width: 70%; }

    .button-container { flex: 1; max-width: 30%; }

    You'll just have to adjust the flex value based on the desired distribution. I Also noticed that you're based in South Africa. It's always wonderful to connect with fellow developers, especially when we're all on a learning journey. If you're open to it, I'd be delighted to connect, share insights, and learn together. thank you

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub