Looking to hire developers?
hi, this one was a pretty straight forward layout, i put a few cute animation on hover on the anchors, if you could give me some feedback it will be appreciate
@samuelpalaciosdev
Posted
By the way👀. I Just noticed that you don't have a placeholder on the input, could bring some problems for the users because they wouldn't know what to put on the input. You should add a placeholder on the <input> in this challenge the placeholder says: "Your email address...". Hope this helps you ;-)
@samuelpalaciosdev
Posted
Hello, again, Luis👋
Great job on this challenge. Your solution looks good and it scales pretty well and I really like the animation you put on the social media buttons👍
I only suggest some things 😉:
-Checking the mobile viewport. On Mobile, the dashboard is too big to fit in the specified area that creates a "scrollbar" you should check that, that comes along with the overflow CSS property.
-Taking care of accesibility issues. That input for the email should have the type of <input type="email"> yo have it as an <input type="text">. Litle details that makes the difference.
-Again, changing the buttons to an <a> (anchor link). If this would be an actual webpage, those buttons should redirect somewhere.
I hope you have a nice day, keep coding!💙
@Comet466
Posted
@samuelpalaciosdev hi samuel thanks once again for your feeedback, you are right after the 300px width the scroll bar takes over the content space, im gonna fix that putting a margin in the body in the media query, about changing the buttons to an anchor, the button has an anchor inside of himself so on click it will redirect to the specified site, the reason that i used a button instead of just an anchor is because i read that it makes easier the interaction with the DOM probably more for cases that you need an event delegation pattern o something of the sort, but in this one probably is better to just use an anchor as you say, i dunno how could i ignore the placeholder oh the input, thanks again for your feedback it really help me to put some things on perspective
@samuelpalaciosdev
Posted
Oh, didn't know that about the DOM, I will research about it, and, no problem Luis, I'm glad to help you, have a nice day!
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
