Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

plain js, SASS, BEM notation

MichalTrubini•1,220
@MichalTrubini
A solution to the FAQ accordion card challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hi there,

I have used plain javascript, as jQuery is kinda cheating (easy way out). :-)

I was also thinking about adding a sliding animation when a question is clicked on, however, the height of the answer div is not the same in all the instances, so I am not sure how to animate it. The solutions I found online required to use a specific height in px.

Thanks for the feedback.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Byron•2,290
    @byronbyron
    Posted over 3 years ago

    Hi Michal

    Not sure if you've come across transitioning the max-height instead. Works best when you know the height will never go above a certain value, in this case 100px.

    .answer__body {
        padding: 0;
        line-height: 1.8rem;
        width: 90%;
        max-height: 0;
        overflow: hidden;
        transition: max-height 1s;
    }
    
    .answer-visible {
        max-height: 100px;
    }
    
    .answer-visible p {
        margin-bottom: 1.5rem;
    }
    
    <div class="answer__body answer-visible" data-selected="1">
        <p>You can invite up...</p>
    </div>
    

    Everything else looks good! 👍

    Marked as helpful
  • MichalTrubini•1,220
    @MichalTrubini
    Posted over 3 years ago

    Hi Byron,

    This was a great suggestion. The answer was so simple: instead of height, use max-height!

    I had to add "line-height: 0" to the answer__body class and "line-height:1.8rem" to answer-visible for it to work. Also, added padding to animation so that there was no stutter.

    There is one small bug still which I need to figure out: slide-down is animated, but slide-up is not, even though I added the transition attribute to answer__body.

    Cheers!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub