Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 4 years ago

Pod Request Access Landing Pages with CSS Grid, Flexbox and JavaScript

Brendan•170
@brendanmadden
A solution to the Pod request access landing page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hi everyone,

I would really appreciate any feedback on how I can do a better job of creating more responsive layouts from the outset, without needing to do so much in my media queries.

If anyone has any thoughts, or can point me in the right direction, I would really appreciate it!

This is my 5th completed Frontend Mentor challenge! I learned a lot about JavaScript and Client-side form validation for this one, and I used CSS Grid more effectively than I have in the past.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Grace•32,130
    @grace-snow
    Posted almost 4 years ago

    Hello

    I’m afraid this looks very broken on mobile landscape at the moment. A reason might be a height 100vh instead of min-height somewhere, and its trying to show the desktop layout already when there isn’t room for it.

    I recommend you take some time to focus learning on semantic html structure. That will help you plan your layouts better anyway.

    And then address the specific issues on this

    • missing header element
    • inaccessible form (input not labelled, error message not linked to the input, no aria-live on the error element, missing button type)
    • look into srcset or the picture element when you need to swap an image at a particular breakpoint.
    • duplicate html - If you find yourself needing to repeat chunks of html content that’s a sign there is a problem with the layout approach. With planning you should be able to display the same content in different layouts
    • there is no need to duplicate css code in media queries if the contidion would already be met by the previous one
    • you will find layouts easier, have shorter and more performant code if you style mobile first instead
    • try not to include elements in html that don’t need to be there (eg decorative content). If it’s not meaningful content, could you use a pseudo element and/or background image instead

    I hope this is helpful

    Marked as helpful
  • P
    Patrick•14,265
    @palgramming
    Posted almost 4 years ago

    Well it looks good but you need to work on your validation cause this a@a currently validates as a correct email

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub