Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 11 months ago

product-list-with-cart app demo using (react redux js css)

react, redux
MarwanElZaher•40
@MarwanElZaher
A solution to the Product list with cart challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I developed a product list with a cart feature using React and Redux. The application allows users to browse products, add them to their cart, and view the cart with a detailed breakdown of items and their quantities. The project also includes functionality for calculating the total cart value based on the selected items. a model to be previewed on submitting the order, then starting a new order.

What challenges did you encounter, and how did you overcome them?

I enhanced my skills in Redux state management by using objects over arrays for better performance and easier access to items by key. I also learned the importance of structuring my Redux state to handle complex features like the cart, where I used the product name as the key. Additionally, I focused on creating reusable and maintainable components, like CartProductDetail, to organize the codebase better. I also got to dive deeper into using CSS for styling and maintaining clean, readable code throughout the project.

What specific areas of your project would you like help with?

I need support in reviewing my code to ensure it aligns with clean code principles. I'm particularly interested in feedback on the readability, simplicity, and maintainability of my code. I would appreciate a detailed review to identify any areas where I could improve my coding practices, such as naming conventions, code structure, and the use of functions.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Teodor Jenkler•4,040
    @TedJenkler
    Posted 11 months ago

    Hi @MarwanElZaher,

    Nice project! It’s fully responsive, so great job on that.

    I noticed you’re using Create React App, which some people consider less optimal for bundling React projects. You might want to explore Vite or other modern tools to enhance your setup.

    For better organization, I’d suggest placing Redux components in separate folders. For example, put your store configuration in app/store.js and slice logic in features/state/stateSlice.js, or features/newLogic/newLogicSlice.js if more logic is added in the future. Typically, for larger projects, components are organized into one folder, with separate folders for pages and modules. Avoid deeply nesting everything in one folder.

    Consider naming and placing files like constants.js and data.js in the root directory. This can help reduce unnecessary nesting and make your project easier to navigate, especially as it grows.

    Overall, your project works well, and I didn’t find any bugs during my scan in DevTools.

    I hope this feedback is helpful!

    Best, Teodor

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub