Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product preview card component - Responsive (HTML and CSS)

@Slaks97β€’ 180

@Slaks97

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I really struggled with the mobile version.

  1. Which properties do I need to use to make the hero-img fit inside its parent? It would either spill over the parent div, or not fully stretch horizontally/vertically, and all sorts of mishaps. I found a way to make it work but I'm sure there is a 'cleaner' way!

  2. I used the properties border-top-left-radius: 10px; and border-bottom-left-radius: 10px; to match the original design. I think I cheated my way around it! Should I have structured my HTML differently so that the hero-img automatically inherit the border-radius property of its parent?

Thanks!

Community feedback

Abdul Khalid πŸš€β€’ 72,100

@0xabdulkhalid

Posted

Hello there πŸ‘‹. Congratulations on successfully completing the challenge! πŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

PiCTURE TAG πŸ“Έ:

  • Looks like you're currently using single image for both Desktop & Mobile devices, but we want to swap images according to their screen sizes. Luckily there's a native html element which may help us to achieve this method without need of css
  • So let me introduce the picture element.
  • The <picture> tag is commonly used for responsive images, where different image sources are provided for different screen sizes and devices, and for art direction, where different images are used for different contexts or layouts.
  • Example:
<picture>
<source media="(max-width: 768px)" srcset="small-image.jpg">
<source media="(min-width: 769px)" srcset="large-image.jpg">
<img src="fallback-image.jpg" alt="Example image">
</picture>
  • In this example, the <picture> tag contains three child elements: two <source> elements and an <img> element. The <source> elements specifies different image sources and the conditions under which they should be used.
  • Using this approach allows you to provide different images for different screen sizes without relying on CSS, and it also helps to improve page load times by reducing the size of the images that are served to the user
  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

.

I hope you find this helpful πŸ˜„ Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

0

@Slaks97β€’ 180

@Slaks97

Posted

Hi @0xAbdulKhalid!

Thank you so much for your feedback and for your detailed reply, very helpful indeed!

I don't think I've ever come across the <picture> property yet it seems to be a very useful tool to use for all the reasons you talk about.

I'll definitely implement your suggestion...and I'll have a look at your submission :)

Thanks again!

0

@graynneji

Posted

To make the hero-img fit inside its parent div, you can use the object-fit property with a value of cover. This will scale the image to be as large as possible while still fitting inside its container, without distorting its aspect ratio.

To make the image have rounded corners to match the design, you can use the border-radius property on the parent div. This will apply the same rounded corners to the image as well, without the need for additional styles.

<div className="hero-container">
<img
src="https://www.linkpicture.com/q/image-hero.jpg"
alt="Hero Image"
className="hero-img"
/>
</div>
.hero-container {
position: relative;
height: 300px;
overflow: hidden;
border-radius: 10px;
}

.hero-img {
position: absolute;
top: 0;
left: 0;
width: 100%;
height: 100%;
object-fit: cover;
}

With these styles, the hero-img will be positioned absolutely inside its parent container, with a width and height of 100% to fill the container.

I hope this helps

Marked as helpful

0

@Slaks97β€’ 180

@Slaks97

Posted

Thank you so much for your input @graynneji!

I am not that fluent with the position property but I will play around with the code you kindly suggested and learn from it.

It does make a lot of sense though and I cannot wait to try it out :)

Thanks again!

0
Luka Glontiβ€’ 3,420

@lack21

Posted

Excellent work πŸ‘, but I have a suggestion!

  • Replace height: 100vh to min-height: 100vh in the body, the difference is that, when you set height: 100vh to something, that means it won't be bigger than that, it might cause some problems in the future, so better approach is to set min-height: 100vh, like this in case content is overflowing container will adjust to it!

Marked as helpful

0

@Slaks97β€’ 180

@Slaks97

Posted

Thank you so much @lack21!

You've explained that clearly and I cannot wait to try it out :)

Thanks again!

0
Dessidyβ€’ 300

@Dessidy

Posted

In your .container class use:

overflow: hidden; This will.make any overflowing content to be hidden, that's it basically, you can refer to my solution if it you think it will be of any help though.

Hope this helpsπŸ˜…

0

@Slaks97β€’ 180

@Slaks97

Posted

Thanks for your input @Dessidy, I will try that :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord