Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product preview card (HTML, CSS, Responsive)

Teri 30

@teriapp

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I enjoyed this project, but I had trouble aligning the old price so that it was midway to the new price. Can anyone please tell me how I could have achieved this? Other feedback is greatly appreciated. Thank you.

Community feedback

Abdul Khalid 70,320

@0xabdulkhalid

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.
  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states
  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.
  • For this demonstration we use css Grid to center the component.
body {
min-height: 100vh;
display: grid;
place-items: center;
}
  • Now remove these styles, after removing you can able to see the changes
.container {
margin: auto;
margin-top: 150px;
}
  • Now your component has been properly centered

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

1

Teri 30

@teriapp

Posted

@0xAbdulKhalid thank you very much, this worked.

0
XIII 790

@minibrusp

Posted

there are two options i can give to you

  • adding these styles to p.saleprice class

display: flex; justify-content: flex-start; align-items: center; gap: 1rem;

  • restructuring the html for div.price making both p.saleprice and span.oldprice as siblings then adding the above styles to div.price

Marked as helpful

1

Teri 30

@teriapp

Posted

@minibrusp this worked, thank you.

0

@mack14

Posted

i think you can target the old price and give it some bottom padding or if it is in the div you can tex align in center.

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord