Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product preview card

@ashutoshbisoyi

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Ahmed Bayoumi 6,800

@Bayoumi-dev

Posted

Hey Ashutosh, It looks good!... Here are some suggestions:

  • Document should have one main landmark, Contain the component with <main>.
<main>
   <div class="container flex-center">
      //...
   </div>
</main>
  • Add cursor: pointer; to the button, The cursor indicates to users there is an action that will be executed when clicking on it.

  • Use REM for font size, It is a must for accessibility because px in some browsers doesn't resize when the browser settings are changed... See this article ---> CSS REM – What is REM in CSS?

I hope this is helpful to you... Keep coding👍

Marked as helpful

0

@ashutoshbisoyi

Posted

@Bayoumi-dev Thank you for the helpful suggestions. I'll bring them to practice

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord