Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Profile Card Component

MakMao 180

@MakMao

Desktop design screenshot for the Profile card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback more than welcome :)

Community feedback

P
Ken 4,915

@kens-visuals

Posted

Hey @MakMao 👋🏻

I have some suggestions to help you fix the accessibility issues and some other things.

  • In your markup, <div class="card">...</div> should be <main class="card">...</main>and this will fix the accessibility issues. Only don't forget to generate a new repot once you fix the issues.
  • For the background pattern image, add aria-hidden="true”, because it's for decoration. You can read more about aria-hidden here. Like so:
<img src="images/bg-pattern-card.svg" alt="">
  • And for the profile picture, alt tag should have the name of the person, such as: <img class="avatar" src="images/image-victor.jpg" alt="Victor Crest">

I hope this was helpful 👨🏻‍💻 other than that, you did an excellent job, well done. Cheers 👾

Marked as helpful

1
MakMao 180

@MakMao

Posted

Hi @Ken,

Thank you for your feedback - I adjusted it all right away. I was not aware of the purpose of aria-hidden but now it's all clear to me:)

0
Matia 20

@Mahmoud-Atia-Abbass

Posted

Great job,, to make it pixel perfect you need to make the Avatar "img" size match the design size.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord