Skip to content
OverviewSolutions
13
Comments
6

MakMao

@MakMaoHolland180 points

Dutchie persuading to become a web dev.

Latest solutions

View more solutions

Latest comments

  • MakMao•180
    @MakMao

    Hey @Manojraj07

    Your solution looks good - it is very close to the design:)

    One thing I noticed is that you did not center your solution vertically even though you used flex and align-items: center;. The default height is zero which means that if you add min-height: 100vh; to your body you will also have it centered vertically. Hope that helps.

    Marked as helpful
  • MakMao•180
    @MakMao

    @Manoj

    Thanks for letting me know - overlooked that part:) Will do!

    Happy coding!

  • MakMao•180
    @MakMao

    Hi,

    Make sure to set a white background on your border. This will solve the problem.

  • MakMao•180
    @MakMao

    @Hetesh Thanks a lot, I agree with you.

  • MakMao•180
    @MakMao

    Hi @Ken,

    Thank you for your feedback - I adjusted it all right away. I was not aware of the purpose of aria-hidden but now it's all clear to me:)

  • MakMao•180
    @MakMao

    Hi, your end result looks okay so that's a win for sure:)

    In terms of your way of writing code, I think it's a bit messy. I think it would be best for you to learn about BEM (Block-Element-Modifier) in order to structure your code better. This is especially handy when working on bigger projects. You will also learn about why it's better (in most cases, let's leave out JS usage for now) to use classes instead of id's.

    https://sparkbox.com/foundry/bem_by_example

    Good luck!

    Marked as helpful