All comments

• 

  Manoj• 245

  @Manojraj07

  Submitted over 2 years ago

  Hi there,

  Try out the click events and validations set on the input field and let me know if you find anything missing.

  Thank you!

  

  Responsive base apparel coming soon page[Using vanilla CSS & JS]

  3

  1

  0

  

  MakMao• 180

  @MakMao

  Posted over 2 years ago

  Hey @Manojraj07

  Your solution looks good - it is very close to the design:)

  One thing I noticed is that you did not center your solution vertically even though you used flex and align-items: center;. The default height is zero which means that if you add min-height: 100vh; to your body you will also have it centered vertically. Hope that helps.

  Marked as helpful

  1
• 

  MakMao• 180

  @MakMao

  Submitted over 2 years ago

  Hey guys,

  Feel free to provide me with feedback. Have a nice weekend!

  

  Coming soon page - html, css and vanilla JS

  2

  1

  0

  

  MakMao• 180

  @MakMao

  Posted over 2 years ago

  @Manoj

  Thanks for letting me know - overlooked that part:) Will do!

  Happy coding!

  0
• 

  Udochukwu Amaefule• 570

  @UDsGitHub

  Submitted over 2 years ago

  Thank you once again Frontend mentor for this design. I would like to ask for feedback and help from the community on how to remove the thin gap between the border and the profile image I have there.

  Best, Udochukwu Amaefule.

  

  Simple Profile Card Component Using basic HTML and CSS

  1

  1

  0

  

  MakMao• 180

  @MakMao

  Posted over 2 years ago

  Hi,

  Make sure to set a white background on your border. This will solve the problem.

  0
• 

  MakMao• 180

  @MakMao

  Submitted over 2 years ago

  Hey guys,

  I wasn't too sure about the HTML used in terms of the semantic meaning. For example: I chose to leave the main tag out as I used the section and article tags instead. Would love to get some feedback on that. Oh, and on the CSS as well of course.

  Thanks!

  

  Social Proof Section - focus on CSS grid

  2

  1

  0

  

  MakMao• 180

  @MakMao

  Posted over 2 years ago

  @Hetesh Thanks a lot, I agree with you.

  0
• 

  MakMao• 180

  @MakMao

  Submitted over 2 years ago

  Any feedback more than welcome :)

  

  Profile Card Component

  3

  1

  0

  

  MakMao• 180

  @MakMao

  Posted over 2 years ago

  Hi @Ken,

  Thank you for your feedback - I adjusted it all right away. I was not aware of the purpose of aria-hidden but now it's all clear to me:)

  0
• 

  Aye Thandar• 20

  @10598ayethandar

  Submitted over 2 years ago

  This is my first project using html and Css.I really need feedback for my very first challenge.Please teach me and tell my mistakes to rise my front end developer skill.I decide to continue learning in front end development.My html and Css code are old because I learn html and css by myself using website and course.I continue learning in javascript, bootstrap and jQuery.So I really need feedbacks for my first time challenges.Thanks you all.

  

  Order_Summary-Component-Main using html and CSs

  2

  1

  0

  

  MakMao• 180

  @MakMao

  Posted over 2 years ago

  Hi, your end result looks okay so that's a win for sure:)

  In terms of your way of writing code, I think it's a bit messy. I think it would be best for you to learn about BEM (Block-Element-Modifier) in order to structure your code better. This is especially handy when working on bigger projects. You will also learn about why it's better (in most cases, let's leave out JS usage for now) to use classes instead of id's.

  https://sparkbox.com/foundry/bem_by_example

  Good luck!

  Marked as helpful

  0

  This comment has received 1 replyShow