@kenreibman
Posted
The card sizing looks great!
I suggest you add some padding
to the left and right for card_footer
to have the spacing closer.
I would also change the font size and font weight of certain text and also align certain items center to more accurately match the original design.
To clear the accessibility issues I would:
- change your
<div class="container">
to<main class="container>
I would also do the same for the attribution
as well by either:
- changing the
div
tofooter
or wrapping the entire div with afooter
tag. - Although this is supposed to be a small component of a larger document, I see that you have not used a
heading
tag in your document. Always have anh1
in your document that increases in chronological order.
Don't forget to generate a new report after you make those changes!
Since bg-pattern-bottom.svg
and bg-pattern-top.svg
are decorations, I would change your HTML to:
<img src="./images/bg-pattern-bottom.svg" alt="" aria-hidden="true">
<img src="./images/bg-pattern-top.svg" alt="" aria-hidden="true">
This is for screen readers, which should be taken into account for best practice.
You can read more about aria-hidden
here
I hope this helps! Keep it up :)
Marked as helpful
@saepulmalik27
Posted
@lmaoken thanks bro, very detail and very helpful