Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

profile card component, using : css, html

Saepul Malik (Malik)•210
@saepulmalik27
A solution to the Profile card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


need your feedback, please kindly give me a feedback

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Ken•935
    @kenreibman
    Posted over 3 years ago

    The card sizing looks great!

    I suggest you add some padding to the left and right for card_footer to have the spacing closer.

    I would also change the font size and font weight of certain text and also align certain items center to more accurately match the original design.

    To clear the accessibility issues I would:

    • change your <div class="container"> to <main class="container>

    I would also do the same for the attribution as well by either:

    • changing the div to footer or wrapping the entire div with a footer tag.
    • Although this is supposed to be a small component of a larger document, I see that you have not used a heading tag in your document. Always have an h1 in your document that increases in chronological order.

    Don't forget to generate a new report after you make those changes!

    Since bg-pattern-bottom.svg and bg-pattern-top.svg are decorations, I would change your HTML to:

    <img src="./images/bg-pattern-bottom.svg" alt="" aria-hidden="true">
    <img src="./images/bg-pattern-top.svg" alt="" aria-hidden="true">
    

    This is for screen readers, which should be taken into account for best practice. You can read more about aria-hidden here

    I hope this helps! Keep it up :)

    Marked as helpful
  • hassan ABD•865
    @hassanabd22
    Posted over 3 years ago

    Good Job Saepul Malikو But you need some small adjustments, such as making the title bold and the numbers as well

  • Zineb Boutaa•750
    @zineb-Bou
    Posted over 3 years ago

    Hi there, here are some notes that may help you to improve your code even better,

    -There is a huge horizontal overflow, check the background images I think this is what makes the background have this huge overflow.

    -Avoid putting an explicit height, I noticed you are giving your card a height, this won't allow it to shrink to fit the content inside when it grows.

    -You can hide the background images from the screen reader since they are just for decoration using aria-hidden: true

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub