Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 4 years ago

Profile Card Component using HTML and CSS

Rodrigo Gamboa•10
@RodrigoGamboa
A solution to the Profile card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


This is my first challenge in Frontend Mentor. Feedback is appreciated :)

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Szymon Rojek•4,540
    @SzymonRojek
    Posted over 4 years ago

    Hi Rodrigo;

    Well done! Congrats.

    I've just checked your HTML structure and preview site by the inspector. A few tips from me:

    • you didn't use the h1 tag, but IMO you can, even with the class hidden sr-only for the screen readers (accessibility it is a very important subject);
    • I am thinking about h2 tag for these numbers; IMO it is not necessary but maybe I can be wrong;
    • I'd recommend learning about semantic tags (why they matter) or how to write meaningful alt text. Divs are semantically inert elements — elements that don’t really do or say anything. "Semantic elements" are elements designed to mark up the structure of a document in a more meaningful way, a way that makes it clear what they're for, what purpose they serve in the document.
    • inside of the alt text you can simply type just the name without image, because the tag img indicates that this is a picture.
    • the hr tag is not necessary here (try to do without it);
    • the circles are a bit tricky in this challenge: I have used pseudo-elements, position absolute, vw and vh, background url, transform translate and @media (in your solution they are not very stable on different devices);

    That's it from me. Ps. Don't forget to upvote any comments on here that you find helpful.

    Greetings :D

  • Amir Jacobs•165
    @Amir-Jacobs
    Posted over 4 years ago

    Hey Rodrigo,

    I've taken a quick look and I noticed the following:

    • Instead of width: 375px I'd use width: 100%; max-width: 375px as this helps with responsive.
    • The blue background pattern images don't show up on mobile.
    • I'd add a margin to the sides of the page on mobile, so that the card doesn't touch the edges. Something like 5px to 15px should be perfect.
    • You could use the BEM method for your CSS. Not really necessary here as it's pretty clear, but I'd look into it nonetheless.

    Your code looks clean. Have a nice day. 😊

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub