@SzymonRojek
Posted
Hi Renszo,
Amazing job. Fun. I like this animation and numbers, really cool effect. I would like to mention just a few details:
- in the article, you can use the header tag, but it is not very necessary, what do you think?
- innerText vs textContent; have a look this MDN;
- transfer .DS_Store to the .gitignore;
That's it from me. Ps. Don't forget to upvote any comments on here that you find helpful.
Greetings :D
@RenszCamacho
Posted
@SzymonRojek Yooo! Thank you for take your time and check, I really found very valuable all your advice, you got my upvote on most of them. I learn a lot from them.
-
I was looking at some online newspapers, how they structure their Html articles, and most of them could just have a footer. I think have more than one header could be confusing for people who use a screen reader. I'm not sure tho.
-
I've just done it. Priceless information.
-
You right, even the fronted mentor files say that. I always forget.
Cheers mate. I do appreciate your feedback.
@SzymonRojek
Posted
@RenszCamacho
That's kind of you. HTML, hmmm to be honest, it is very tricky for me all the time, sometimes even annoying because lots of things are going on here. I think after a while we will see things naturally, structurally :D
Have a look at this: => W3C about article tag;
@SzymonRojek
Posted
@RenszCamacho
I know what you mean, but here we have got a single page - one component (there is h1, p, img ) so IMO it will be ok but it is not a final oracle :D
@RenszCamacho
Posted
@SzymonRojek Yes, I know, I realize that underestimate Html. I will improve or so I hope.
Thank you again. 🙇♂️
@SzymonRojek
Posted
@RenszCamacho
Hi again,
I have read this note about the header and I would like to share with you, of course, it is not about your project above, just generally - using header a few times doesn’t affect the web outline algorithm. It is not sectioning content and therefore does not introduce a new section in the outline.
Header is a flow content category - this element must not be a descendant of an address, footer or another header element.
Check it out: => link;
“HTML Header Element (header) defines a page area that typically contains a logo, title, and navigation. The header can also be used inside other semantic elements such as article or section. A section header might contain the section's heading, author name, etc. article, section, aside, and nav can have their own header. Despite its name, the header is not necessarily positioned at the beginning of a page or section”. => link.
Let me know what do you think about it :D
@RenszCamacho
Posted
@SzymonRojek My friend, very enlightening and well summed up on your part. I'm going to have to redo my current challenge and try to improve my HTML. Nothing to say, just thank you.
Have a good day!
