Submitted about 3 years ago

Profile card / SASS, Flexbox, Grid

Xuan-Tam• 40

@xuantam-h

Preview site View code

This is a solution for...

Profile card component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

Simple profile card challenge using Flexbox and Grid to design the card. Any feedback would be greatly appreciated ! I want to improve.

Community feedback

Ana Luz Cervantes• 1,705

@analuzcervantes

Posted about 3 years ago

Hi! 🖖

Your design looks pretty good.

I would only recommend you to change the background-position by right 50vw bottom 50vh, left 50vw top 50vh That way the background will adapt

Here is more information about vw and vh

Be well, keep coding! 💻👾

Xuan-Tam• 40

@xuantam-h

Posted about 3 years ago

@analuzcervantes Thank you so much for your feedback. I actually did use viewport units for the body but I didn't consider using it for the background-position. I'll definitely use this on background as well !

Samuel Palacios• 615

@samuelpalaciosdev

Posted about 3 years ago

Hi, Xuan-Tam👋

Great job on this challenge. Your solution looks good and it scales pretty well👍

I only suggest some things 😉:

You don't have a h1 on this project as it stands. Having your headings on order is not really a rule, but the h1 it's one of the most important tags on an webpage . For this project, it would be where you've got the h2 heading.

I hope this would help you, have a nice day, keep coding!💙

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord