@rngueco
Posted
Hey Inan! This was an interesting approach!
I still think using Flexbox or Grid is better for this project, so you don't have to explicitly set a width and height for your container. Viewing this on a big screen (> 1440px), all the whitespace surrounding your content card starts to be visible. On a medium screen (~ 600px), it would be nice if all the content fits within the screen and there's no extra space to the right or to the left.
Other than that, the details inside all-footer would be better off inside a list element like <ul> or <ol> just to be a bit more semantic with your HTML.
Cheers and happy coding!
Marked as helpful
@inanbruneli
Posted
@rngueco Hey. You are right, I need to use flexbox anyway. I also did'nt know about the responsive, I just create for the width in the design. Thank you very much for the feedback, I am going to do the changes (:
