Profile-card component

Solution retrospective
Feedbacks are welcome
Please log in to post a comment
Log in with GitHubCommunity feedback
- @grace-snow
Hi
The big things that need fixing on this are
- html - you've used no meaningful elements at all.
- html should not be display flex or styled like the body
- no height should be on the card at all, just a min height if needed on the pattern image at the top of the card.
- At the moment content is spilling out on mobile landscape probably due to heights and relative positioning used
- content stacks by default so you shouldn't be using all those position relatives with percentage from top. That's not needed and causing problems with the size of card and positions.
- use width 100% and max-width on the card instead.
I hope this helps
- P@palgramming
As you can see in screen-capture comparison your overall card shape is not correct. You are also missing the horizontal line element between London and the Social data counts
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord