Ahmed Bayoumi• 6,800
@Bayoumi-dev
Posted
Hey Danny,
My suggestions:
Page should contain a level-one heading
, Changeh2
toh1
You should always have oneh1
per page of the document... in this challenge, you will useh1
just to avoid theaccessibility issue
that appears in the challenge report... but don't useh1
on small components<h1>
should represent the main heading for the whole page, and for the best practice use only one<h1>
per page.All page content should be contained by landmarks
, Contain the attribution with<footer>
.
<footer>
<div class="attribution">
//...
</div>
</footer>
- I suggest you put the status of the profile card into the
list item
to add moresemantics
to your project,Div
's don't do much for semantics but a list is much more meaningful..:
<ul class="stats">
<li><span class="stats-num">80K</span>Followers</li>
<li><span class="stats-num">803K</span>Likes</li>
<li><span class="stats-num"> 1.4K</span>Photos</li>
</ul>
Hope this is helpful to you... Keep coding👍
0
DanMo• 120
@DannyMolina
Posted
Hello @Bayoumi-dev , I am very grateful that you have taken the time to review my work and I received your suggestions and made the respective changes. Thank you very much there are things that I still do not understand in terms of semantics
0