Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Project tracking intro component using css

@fadzrinmadu

Desktop design screenshot for the Project tracking intro component coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


please review my code and let me know what i need to improve. thanks in advance

Community feedback

P
Matt Studdert 13,611

@mattstuddert

Posted

Great work again Muhammad! Your code looks great. One way you could make your Sass styles a bit easier to maintain, especially when you build larger projects, would be to nest the media queries inside the declaration blocks. So instead of this:

@media screen and (min-width: 992px) {
  .menu-toggle { display: none; }
}

You could do this:

.menu-toggle {
  @media screen and (min-width: 992px) {
    display: none;
  }
}

This keeps the styles for all screen sizes in the same area in your code, which is easier to manage. You would then use variables to define the main breakpoints.

I hope that helps! Let me know if you have any questions.

1

@fadzrinmadu

Posted

@mattstuddert thank you this is very helpful, i will apply it also to the next challange

0
P
Matt Studdert 13,611

@mattstuddert

Posted

@fadzrinmadu you're welcome. Happy to help!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord