Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code

@PaliTriesToDesign

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Is it needed to put the image inside a div? It still confuses me a bit.

I feel like I'm learning something. It only took me about 20 minutes to build it.

Thanks!

Community feedback

TechNech 340

@TechNech

Posted

Hope you are doing good. I would suggest you these few quick fixes on your component site.

  • In your .container you don't need that much of margin you can do is to simplify that property to margin: 0 auto

  • Then add these properties height: 100vh; display: flex; flex-direction: column; justify-content: center; to your body css, which will center your component.

  • In .qr-text simplify padding: 1rem;

  • In your .qr-text__p add max-width: 25ch;

Marked as helpful

1

@PaliTriesToDesign

Posted

@TechNech I really appreciate your help. Thanks!

0
TechNech 340

@TechNech

Posted

@PaliTriesToDesign Anytime! I would love to see those changes on the live site. Make those changes and push it on github.

Happy coding :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord