Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

QR code card with HTML and CSS

Brstone2002•20
@Brstone2002
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

Proud I was able to do my first challenge on my own, with little googling. Just improve in general with every challenge I do.

What challenges did you encounter, and how did you overcome them?

Just trying to remember how basic things work in general without relying on google constantly. Had to google a few times to get on the right track.

What specific areas of your project would you like help with?

Feedback is appreciated.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Grace•32,130
    @grace-snow
    Posted over 1 year ago

    First, I'm going to point you to someone else's feedback on the same challenge as you have a lot of the same issues here, especially in the html.

    Looking at your css

    • Always use a modern css reset at the start of the styles in every project. Andy Bell or Josh Comeau both have good ones you can look up and use. It's not strictly necessary for such a tiny project but good to get into the habit of including it every time. The reality is you would never work on any project without one in the real world.
    • I can see a sort of reset at the top but it's not enough and has a serious problem: Don't set width and height to 100% of html and body. I'm not sure where you got that code snippet from but it can cause bugs especially when using flex/grid to center things in the viewport. It is making the content get cut off on screens with a small height.
    • Font size must never be in px. Extremely important!
    • the card must not have a width. Instead give it a max width in rem so that it can shrink narrower when it needs to (eg on smaller screens). Using rem also means the card would scale correctly for all users including those who have a different text size.
    Marked as helpful
  • ildi0818•60
    @ildi0818
    Posted over 1 year ago

    I'm not experienced, so unfortunately I can't give you advice.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub