Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component

@abubakr404

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feedback welcome

Community feedback

P

@GregLyons

Posted

Your solution matches the given design pretty well. I also see that you're using classes (rather than IDs) for styling, which is good for code reusability. Here are some suggestions I have based on your code:

  1. Favor using semantic markup (e.g. <p> for text, <h1>, <h2>, etc. for headings) instead of <div>'s. For styling purposes, like the container for your card, it can be useful to use a <div>, but things like search engines and screen readers use the HTML tags to understand your page. So using semantic markup will make your website more accessible and have better SEO.

  2. I'm not sure it's necessary to wrap your <img> in a <div>, as you should be able to apply "display: block" so that it acts like a block element (text doesn't wrap around it) instead. I believe this is what you intend, as I don't see any styling on your wrapper .QR-img <div>.

Marked as helpful

0

@abubakr404

Posted

@GregLyons Thanks you very much for your interest and great advice.

1
P

@GregLyons

Posted

@abubakr404 No problem, keep up the good work!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord