@Bayoumi-dev
Posted
Hey Surajit, Congratulations on completing this challenge... It looks good!
My suggestions:
Document should have one main landmark
, Contain the component with<main>
.
<main>
<div class="card">
//...
</div >
</main>
-
Page should contain a level-one heading
, Changeh3
toh1
, You should always have oneh1
per page of the document... in this challenge, you will useh1
just to avoid theaccessibility issue
that appears in the challenge report... but don't useh1
on small components<h1>
should represent the main heading for the whole page, and for the best practice use only one<h1>
per page. -
Use
Font-Family: Outfit
as recommended in this challenge to get it looking as close to the design as possible.
Hope this is useful to you... Keep codingπ
Marked as helpful
@SURAJITSHAW
Posted
@Bayoumi-dev Thanks for the suggestions man. You guys are so supportive. I'm about to implement your suggestions to fix the accessibility issues. Thanks again for your time to look at this and give genuine suggestions βοΈβοΈ